Skip to content

Enable API/ABI checks for bigtable. - #2682

Merged
coryan merged 2 commits into
googleapis:masterfrom
coryan:enable-bigtable-abi-check
May 23, 2019
Merged

coryan merged 2 commits into
googleapis:masterfrom
coryan:enable-bigtable-abi-check

Conversation

@coryan

@coryan coryan commented May 23, 2019 •

Copy link
Copy Markdown
Contributor

There are still a couple of changes we may want to make to the API, but
I would prefer to notice those and not miss other breakage.

This fixes #694.


This change is Reviewable

There are still a couple of changes we may want to make to the API, but
I would prefer to notice those and not miss other breakage.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 23, 2019
@codecov

codecov Bot commented May 23, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #2682 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2682   +/-   ##
======================================
  Coverage    93.3%   93.3%           
======================================
  Files         296     296           
  Lines       19077   19077           
======================================
  Hits        17800   17800           
  Misses       1277    1277

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acff376...cb7c9c6. Read the comment docs.

Comment thread ci/check-abi.sh Resolved
@coryan

coryan commented May 23, 2019

Copy link
Copy Markdown
Contributor Author

PTAL.

@codecov-io

codecov-io commented May 23, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #2682 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2682   +/-   ##
======================================
  Coverage    93.3%   93.3%           
======================================
  Files         296     296           
  Lines       19077   19077           
======================================
  Hits        17800   17800           
  Misses       1277    1277

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acff376...cb7c9c6. Read the comment docs.

@coryan
coryan merged commit 34c5339 into googleapis:master May 23, 2019
@coryan
coryan deleted the enable-bigtable-abi-check branch May 23, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable build breakage when bigtable ABI is declared stable.

4 participants